Skip to content
This repository has been archived by the owner on Dec 10, 2024. It is now read-only.

API Explicity mark nullable parameters for PHP 8.4 #4

Merged

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Nov 28, 2024

Issue silverstripe/.github#331

Manually tag 3.99.100 after merge

@emteknetnz emteknetnz marked this pull request as draft November 28, 2024 01:23
@emteknetnz emteknetnz changed the title API Explicity mark nullable paramters for PHP 8.4 API Explicity mark nullable parameters for PHP 8.4 Dec 1, 2024
@emteknetnz emteknetnz marked this pull request as ready for review December 2, 2024 20:38
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit 2eb46cc into silverstripe:master Dec 2, 2024
@GuySartorelli GuySartorelli deleted the pulls/master/php84 branch December 2, 2024 21:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants